Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1768013002: X87: [compiler] Introduce code stubs for string relational comparisons. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Introduce code stubs for string relational comparisons. port 5912e0f014bd7b7d52cdc293145a912a4ecf2cf3(r34485) original commit message: Add StringLessThanStub, StringLessThanOrEqualStub, StringGreaterThanStub and StringGreaterThanOrEqualStub, based on the CodeStubAssembler, and hook them up with TurboFan (and Ignition). The stubs are currently essentially comparable with the StringCompareStub, which is now obsolete. We can later extend these stubs to cover more interesting cases (i.e. two byte sequential string comparisons, etc.). BUG= Committed: https://crrev.com/5dbc0e30cb1d6a61e9308c50f2a6fc3d864785f6 Cr-Commit-Position: refs/heads/master@{#34516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-07 02:09:54 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-07 02:18:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1768013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1768013002/1
4 years, 9 months ago (2016-03-07 02:19:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 02:39:03 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 02:39:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dbc0e30cb1d6a61e9308c50f2a6fc3d864785f6
Cr-Commit-Position: refs/heads/master@{#34516}

Powered by Google App Engine
This is Rietveld 408576698