src/runtime.cc - Issue 176793003: Reland and fix "Allow ICs to be generated for own global proxy."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 176793003: Reland and fix "Allow ICs to be generated for own global proxy." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix and regression test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 306042f4ea65601e0e4ed3c5fe57ee08937be87c..55013f1b4e45241f652841ad863113a50ced4615 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -14735,7 +14735,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_IsAccessAllowedForObserver) {

ASSERT(args.length() == 3);

CONVERT_ARG_HANDLE_CHECKED(JSFunction, observer, 0);

CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 1);

- ASSERT(object->IsAccessCheckNeeded());

+ ASSERT(object->map()->is_access_check_needed());

Handle<Object> key = args.at<Object>(2);

SaveContext save(isolate);

isolate->set_context(observer->context());

« no previous file with comments | « src/objects-inl.h ('k') | test/mjsunit/regress/regress-store-global-proxy.js » ('j') | no next file with comments »