Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 176793003: Reland and fix "Allow ICs to be generated for own global proxy." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix and regression test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1286 } 1286 }
1287 1287
1288 1288
1289 #undef __ 1289 #undef __
1290 #define __ ACCESS_MASM(masm()) 1290 #define __ ACCESS_MASM(masm())
1291 1291
1292 1292
1293 Handle<Code> StoreStubCompiler::CompileStoreInterceptor( 1293 Handle<Code> StoreStubCompiler::CompileStoreInterceptor(
1294 Handle<JSObject> object, 1294 Handle<JSObject> object,
1295 Handle<Name> name) { 1295 Handle<Name> name) {
1296 Label miss;
1297
1298 // Check that the map of the object hasn't changed.
1299 __ CheckMap(receiver(), scratch1(), Handle<Map>(object->map()), &miss,
1300 DO_SMI_CHECK);
1301
1302 // Perform global security token check if needed.
1303 if (object->IsJSGlobalProxy()) {
1304 __ CheckAccessGlobalProxy(receiver(), scratch1(), &miss);
1305 }
1306
1307 // Stub is never generated for non-global objects that require access
1308 // checks.
1309 ASSERT(object->IsJSGlobalProxy() || !object->IsAccessCheckNeeded());
1310
1311 __ Push(receiver(), this->name(), value()); 1296 __ Push(receiver(), this->name(), value());
1312 1297
1313 // Do tail-call to the runtime system. 1298 // Do tail-call to the runtime system.
1314 ExternalReference store_ic_property = 1299 ExternalReference store_ic_property =
1315 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate()); 1300 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty), isolate());
1316 __ TailCallExternalReference(store_ic_property, 3, 1); 1301 __ TailCallExternalReference(store_ic_property, 3, 1);
1317 1302
1318 // Handle store cache miss.
1319 __ bind(&miss);
1320 TailCallBuiltin(masm(), MissBuiltin(kind()));
1321
1322 // Return the generated code. 1303 // Return the generated code.
1323 return GetCode(kind(), Code::FAST, name); 1304 return GetCode(kind(), Code::FAST, name);
1324 } 1305 }
1325 1306
1326 1307
1327 Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType> type, 1308 Handle<Code> LoadStubCompiler::CompileLoadNonexistent(Handle<HeapType> type,
1328 Handle<JSObject> last, 1309 Handle<JSObject> last,
1329 Handle<Name> name) { 1310 Handle<Name> name) {
1330 NonexistentHandlerFrontend(type, last, name); 1311 NonexistentHandlerFrontend(type, last, name);
1331 1312
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
1571 // ----------------------------------- 1552 // -----------------------------------
1572 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1553 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1573 } 1554 }
1574 1555
1575 1556
1576 #undef __ 1557 #undef __
1577 1558
1578 } } // namespace v8::internal 1559 } } // namespace v8::internal
1579 1560
1580 #endif // V8_TARGET_ARCH_MIPS 1561 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698