Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 176793003: Reland and fix "Allow ICs to be generated for own global proxy." (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Reland and fix "Allow ICs to be generated for own global proxy." BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19756

Patch Set 1 #

Patch Set 2 : Fix and regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -88 lines) Patch
M src/arm/stub-cache-arm.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/code-stubs.h View 3 chunks +19 lines, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/ic.cc View 1 6 chunks +22 lines, -22 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-store-global-proxy.js View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-25 13:50:43 UTC) #1
mvstanton
lgtm. How come there aren't a64 changes?
6 years, 10 months ago (2014-02-25 14:04:36 UTC) #2
Toon Verwaest
It was modeled after x64, not arm
6 years, 10 months ago (2014-02-25 14:12:23 UTC) #3
Toon Verwaest
6 years, 9 months ago (2014-03-10 12:23:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698