third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h ('k') | third_party/WebKit/Source/web/InspectorEmulationAgent.h » ('j') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp b/third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp

index 4bd0b37f228e5f4b0493c809620a249273394113..858ef39272fc827c2b7a3f020cf7913c67656db5 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp

@@ -6,11 +6,11 @@

namespace blink {

-static String coreString(v8::Local<v8::String> v8String)

+static String16 coreString(v8::Local<v8::String> v8String)

dgozman 2016/03/08 01:35:12 rename method

{

int length = v8String->Length();

UChar* buffer;

- String result = String::createUninitialized(length, buffer);

+ String16 result = String16::createUninitialized(length, buffer);

v8String->Write(reinterpret_cast<uint16_t*>(buffer), 0, length);

return result;

}