third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h

index 01b999235463679e23070774e66c6ce0746909bc..ee3175f22a564346a58a8c27fb7c2a6f50eecaa8 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h

@@ -17,8 +17,8 @@ public:

virtual ~V8ProfilerAgent() { }

// API for the embedder.

- virtual void consoleProfile(const String& title) = 0;

- virtual void consoleProfileEnd(const String& title) = 0;

+ virtual void consoleProfile(const String16& title) = 0;

+ virtual void consoleProfileEnd(const String16& title) = 0;

virtual void idleStarted() = 0;

virtual void idleFinished() = 0;