third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/ThreadDebugger.h ('k') | third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.cpp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

index 777ad126a86e40f736c4ead3701a4bcaf5275b5d..5d8a1d1c4c817b6e0fb6e3a19a06cab5a51c35de 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

@@ -59,7 +59,7 @@ v8::MaybeLocal<v8::Value> ThreadDebugger::callInternalFunction(v8::Local<v8::Fun

return V8ScriptRunner::callInternalFunction(function, receiver, argc, info, m_isolate);

}

-String ThreadDebugger::valueSubtype(v8::Local<v8::Value> value)

+String16 ThreadDebugger::valueSubtype(v8::Local<v8::Value> value)

{

if (V8Node::hasInstance(value, m_isolate))

return "node";