third_party/WebKit/Source/core/inspector/LayoutEditor.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.h » ('j') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

diff --git a/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp b/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

index 2bf86799fa920e889a8b2670bcb52ecfb9452ffe..5e88c0781153c0ef826d4017a3a06359766dd037 100644

--- a/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

+++ b/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

@@ -408,7 +408,7 @@ PassOwnPtr<protocol::DictionaryValue> LayoutEditor::currentSelectorInfo(CSSStyle

bool LayoutEditor::setCSSPropertyValueInCurrentRule(const String& value)

{

- String errorString;

+ ErrorString errorString;

m_cssAgent->setLayoutEditorValue(&errorString, m_element.get(), m_matchedStyles.at(m_currentRuleIndex), m_changingProperty, value, false);

return errorString.isEmpty();

}