third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/InspectorInputAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h » ('j') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp

index 1d2b45ee1406a0a970ade46e48b8cab436c382fe..0b52975a5195dfd032afaa4241beb4499b8839d3 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp

@@ -128,7 +128,7 @@ void InspectorInputAgent::dispatchTouchEvent(ErrorString* error, const String& t

} else if (type == "touchMove") {

convertedType = PlatformEvent::TouchMove;

} else {

- *error = "Unrecognized type: " + type;

+ *error = String("Unrecognized type: " + type);

return;

}

@@ -171,7 +171,7 @@ void InspectorInputAgent::dispatchTouchEvent(ErrorString* error, const String& t

} else if (state == "touchCancelled") {

convertedState = PlatformTouchPoint::TouchCancelled;

} else {

- *error = "Unrecognized state: " + state;

+ *error = String("Unrecognized state: " + state);

return;

}