Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
index 4e3d892dd1fdee39ccf9cd4d9461a9e7237710dd..6649e135c98797b0a817de76a27db65a73132efb 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
@@ -1108,7 +1108,7 @@ void InspectorCSSAgent::setStyleSheetText(ErrorString* errorString, const String
FrontendOperationScope scope;
InspectorStyleSheetBase* inspectorStyleSheet = assertStyleSheetForId(errorString, styleSheetId);
if (!inspectorStyleSheet) {
- *errorString = "Style sheet with id " + styleSheetId + " not found";
+ *errorString = String("Style sheet with id " + styleSheetId + " not found");
dgozman 2016/03/08 01:35:12 template consturctor
return;
}
@@ -1122,7 +1122,7 @@ void InspectorCSSAgent::setStyleSheetText(ErrorString* errorString, const String
static bool verifyRangeComponent(ErrorString* errorString, bool valid, const String& component)
{
if (!valid)
- *errorString = "range." + component + " must be a non-negative integer";
+ *errorString = String("range." + component + " must be a non-negative integer");
return valid;
}
@@ -1704,7 +1704,7 @@ InspectorStyleSheet* InspectorCSSAgent::assertInspectorStyleSheetForId(ErrorStri
InspectorStyleSheetBase* InspectorCSSAgent::assertStyleSheetForId(ErrorString* errorString, const String& styleSheetId)
{
- String placeholder;
+ ErrorString placeholder;
InspectorStyleSheetBase* result = assertInspectorStyleSheetForId(&placeholder, styleSheetId);
if (result)
return result;

Powered by Google App Engine
This is Rietveld 408576698