third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h b/third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h

index 9de313ea5211382df4e268359fd0a6b5eb22bea4..9af348d4ccc31a56abda8a044cc6b08f8791533f 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h

@@ -26,13 +26,13 @@ public:

void asyncCallTrackingStateChanged(bool tracking);

void resetAsyncOperations();

- void didReceiveV8AsyncTaskEvent(v8::Local<v8::Context>, const String& eventType, const String& eventName, int id);

+ void didReceiveV8AsyncTaskEvent(v8::Local<v8::Context>, const String16& eventType, const String16& eventName, int id);

void contextDisposed(int contextId);

private:

struct Operations {

- protocol::HashMap<String, int> map;

+ protocol::HashMap<String16, int> map;

int contextId;

V8AsyncCallTracker* target;

v8::Global<v8::Context> context;

@@ -42,9 +42,9 @@ private:

explicit V8AsyncCallTracker(V8DebuggerAgentImpl*);

- void didEnqueueV8AsyncTask(v8::Local<v8::Context>, const String& eventName, int id);

- void willHandleV8AsyncTask(v8::Local<v8::Context>, const String& eventName, int id);

- void completeOperations(const protocol::HashMap<String, int>& contextCallChains);

+ void didEnqueueV8AsyncTask(v8::Local<v8::Context>, const String16& eventName, int id);

+ void willHandleV8AsyncTask(v8::Local<v8::Context>, const String16& eventName, int id);

+ void completeOperations(const protocol::HashMap<String16, int>& contextCallChains);

V8DebuggerAgentImpl* m_debuggerAgent;

protocol::HashMap<int, OwnPtr<Operations>> m_idToOperations;