third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template

index d81e08cb0ae80aacabe603c27a0708aa40c36e00..ea3a5799e06a2309be96e3dc5a750570d4c83857 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template

@@ -11,16 +11,17 @@

#include "platform/inspector_protocol/Array.h"

#include "platform/inspector_protocol/ErrorSupport.h"

#include "platform/inspector_protocol/Maybe.h"

+#include "platform/inspector_protocol/String16.h"

#include "platform/inspector_protocol/Values.h"

#include "platform/inspector_protocol/ValueConversions.h"

#include "wtf/Assertions.h"

#include "wtf/PassOwnPtr.h"

-#include "wtf/text/StringBuilder.h"

-#include "wtf/text/WTFString.h"

namespace blink {

namespace protocol {

+using ErrorString = String16;

class PLATFORM_EXPORT Object {

public:

static PassOwnPtr<Object> parse(protocol::Value* value, ErrorSupport* errors);

@@ -205,4 +206,6 @@ private:

} // namespace protocol

} // namespace blink

+using blink::protocol::ErrorString;

#endif // !defined({{class_name}}_h)