Lint for `@mustCallSuper` (#194).

Lint for `@mustCallSuper` (#194).

See: https://github.com/dart-lang/linter/issues/194.

WIP but ready for early feedback.

Notably there's no flow analysis so we don't check for a return before the call (for example).  Should we?


Moved to SDK: https://codereview.chromium.org/1773803002/.

BUG=

[pquitslund, 2016-03-04 22:27:41]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[pquitslund, 2016-03-04 22:27:41]

Another work in progress.  Early reactions welcome!

[Brian Wilkerson, 2016-03-04 22:46:28]

I'm not sure why this is a lint rather than a hint, but it LGTM so far.

[pquitslund, 2016-03-06 22:05:25]

On 2016/03/04 22:46:28, Brian Wilkerson wrote:
> I'm not sure why this is a lint rather than a hint, but it LGTM so far.

OK!  I'll migrate.

What do you think about flow analysis?  IOW: what if the call to super is
unreachable?  I'm guessing that's OK as a refinement?

[Brian Wilkerson, 2016-03-07 15:44:01]

> What do you think about flow analysis?  IOW: what if the call to super is
> unreachable?  I'm guessing that's OK as a refinement?

Absolutely. I think it would be fantastic for analyzer to be able to do flow
analysis, and then to integrate that into lints like this, but I think it's more
important to get the 80% case covered quickly. As you said, we can always refine
it later.

[pquitslund, 2016-03-07 20:32:03]

Description was changed from

==========
Lint for `@mustCallSuper` (#194).

See: https://github.com/dart-lang/linter/issues/194.

WIP but ready for early feedback.

Notably there's no flow analysis so we don't check for a return before the call
(for example).  Should we?

BUG=
==========

to

==========
Lint for `@mustCallSuper` (#194).

See: https://github.com/dart-lang/linter/issues/194.

WIP but ready for early feedback.

Notably there's no flow analysis so we don't check for a return before the call
(for example).  Should we?


Moved to SDK: https://codereview.chromium.org/1773803002/.

BUG=
==========