a few small refactorings to closure workarounds

a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove later.
* always emit type parameters in the AST, and pass the flag to the printer to skip printing them.
* cleanup an unnecessary sync* method for closure field decls.
* also, reformats. I think I forgot to do that in previous CL.

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/4b57101ea760a9f2589da63ac7ca29e4b87dc04f

[Jennifer Messerly, 2016-03-04 20:37:02]

Description was changed from

==========
a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove
later.
* always emit type parameters in the AST, and pass the flag to the printer to
skip printing them.
* cleanup an unnecessary sync* method for TypeScript field decls
==========

to

==========
a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove
later.
* always emit type parameters in the AST, and pass the flag to the printer to
skip printing them.
* cleanup an unnecessary sync* method for TypeScript field decls
* also, reformats. I think I forgot to do that in previous CL
==========

[Jennifer Messerly, 2016-03-04 20:37:02]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-03-04 20:37:22]

Description was changed from

==========
a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove
later.
* always emit type parameters in the AST, and pass the flag to the printer to
skip printing them.
* cleanup an unnecessary sync* method for TypeScript field decls
* also, reformats. I think I forgot to do that in previous CL
==========

to

==========
a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove
later.
* always emit type parameters in the AST, and pass the flag to the printer to
skip printing them.
* cleanup an unnecessary sync* method for closure field decls.
* also, reformats. I think I forgot to do that in previous CL.
==========

[Jennifer Messerly, 2016-03-04 20:38:35]

BTW, sorry for the output changes -- what happens is the Symbol order is
sensitive to when certain things are visited. We should improve that IMO --
perhaps put them all in the front.

[vsm, 2016-03-08 23:16:49]

lgtm - sorry for being slow!

[Jennifer Messerly, 2016-03-08 23:56:23]

Description was changed from

==========
a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove
later.
* always emit type parameters in the AST, and pass the flag to the printer to
skip printing them.
* cleanup an unnecessary sync* method for closure field decls.
* also, reformats. I think I forgot to do that in previous CL.
==========

to

==========
a few small refactorings to closure workarounds

* factor the class heritage workaround so it's out of the way & easier to remove
later.
* always emit type parameters in the AST, and pass the flag to the printer to
skip printing them.
* cleanup an unnecessary sync* method for closure field decls.
* also, reformats. I think I forgot to do that in previous CL.

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/4b57101ea760a9f2589da63ac7ca...
==========

[Jennifer Messerly, 2016-03-08 23:56:25]

Committed patchset #1 (id:1) manually as
4b57101ea760a9f2589da63ac7ca29e4b87dc04f (presubmit successful).