Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1767793002: Revert "Only place primitive objects on the V8 global template." (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Only place primitive objects on the V8 global template." This reverts commit 3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1. R=ochang@chromium.org TBR=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -112 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 6 chunks +181 lines, -92 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 2 chunks +0 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
TBR, broke tests.
4 years, 9 months ago (2016-03-04 20:32:46 UTC) #3
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-04 20:33:13 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-04 20:33:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698