Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1767773002: Delete RenderViewImplTest.OnHandleKeyboardEvent. (Closed)

Created:
4 years, 9 months ago by dglazkov
Modified:
4 years, 9 months ago
Reviewers:
esprehn, dtapuska
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete RenderViewImplTest.OnHandleKeyboardEvent. It comes from the old times when we actually had a conversion from native events to blink events. Nowadays, this test just tests itself. BUG=304341 R=dtapuska Committed: https://crrev.com/2c76d1049aed5a8ca9b32459a5633388505fa877 Cr-Commit-Position: refs/heads/master@{#379360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -147 lines) Patch
M content/renderer/render_view_browsertest.cc View 1 chunk +0 lines, -147 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767773002/1
4 years, 9 months ago (2016-03-04 20:21:07 UTC) #2
dtapuska
On 2016/03/04 20:21:07, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-04 20:37:01 UTC) #3
esprehn
lgtm
4 years, 9 months ago (2016-03-04 21:10:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 21:12:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767773002/1
4 years, 9 months ago (2016-03-04 21:13:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 21:23:19 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 21:24:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c76d1049aed5a8ca9b32459a5633388505fa877
Cr-Commit-Position: refs/heads/master@{#379360}

Powered by Google App Engine
This is Rietveld 408576698