Check libpng version before reading color space

Check libpng version before reading color space

TBR=scroggo@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767723003

Committed: https://skia.googlesource.com/skia/+/e244322a9db64b3b54068904a333203ae166d86d

[msarett, 2016-03-04 21:56:39]

Description was changed from

==========
Check libpng version before reading color space

TBR=scroggo@google.com

BUG=skia:
==========

to

==========
Check libpng version before reading color space

TBR=scroggo@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-03-04 21:57:13]

msarett@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-03-04 22:01:07]

LGTM with one nit.

https://codereview.chromium.org/1767723003/diff/1/src/codec/SkPngCodec.cpp
File src/codec/SkPngCodec.cpp (right):

https://codereview.chromium.org/1767723003/diff/1/src/codec/SkPngCodec.cpp#ne...
src/codec/SkPngCodec.cpp:181: #if PNG_LIBPNG_VER_MAJOR == 1 &&
PNG_LIBPNG_VER_MINOR >= 6
what happens when we hit 2.0 ?

[msarett, 2016-03-04 22:03:43]

The CQ bit was checked by msarett@google.com

[msarett, 2016-03-04 22:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com
Link to the patchset: https://codereview.chromium.org/1767723003/#ps20001
(title: "Future proof for version 2")

[commit-bot: I haz the power, 2016-03-04 22:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767723003/20001

[commit-bot: I haz the power, 2016-03-04 22:20:54]

Description was changed from

==========
Check libpng version before reading color space

TBR=scroggo@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Check libpng version before reading color space

TBR=scroggo@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e244322a9db64b3b54068904a333203ae166d86d
==========

[commit-bot: I haz the power, 2016-03-04 22:20:55]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e244322a9db64b3b54068904a333203ae166d86d