Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1767713002:
SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> (Closed)
|
Created:
4 years, 9 months ago by hal.canary Modified:
4 years, 9 months ago Reviewers:
bungeman-skia CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*>
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767713002
Committed: https://skia.googlesource.com/skia/+/91fcb3ed58845ddd5afa98a7150f3024d87c7425
Patch Set 1 #
Total comments: 1
Patch Set 2 : 2016-03-04 (Friday) 14:47:46 EST #Patch Set 3 : 2016-03-04 (Friday) 15:07:08 EST #Patch Set 4 : 2016-03-04 (Friday) 16:05:26 EST #Patch Set 5 : 2016-03-04 (Friday) 16:19:36 EST #Patch Set 6 : 2016-03-04 (Friday) 16:33:27 EST #
Messages
Total messages: 32 (15 generated)
Description was changed from ========== SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> ========== to ========== SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
halcanary@google.com changed reviewers: + bungeman@google.com
ptal
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767713002/1
https://codereview.chromium.org/1767713002/diff/1/include/private/SkTArray.h File include/private/SkTArray.h (right): https://codereview.chromium.org/1767713002/diff/1/include/private/SkTArray.h#... include/private/SkTArray.h:150: * Version of above that uses a move constructor to initialize the new item This says 'above' but the copy push_back is below. Maybe move this implementation to after push_back(constT&)?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767713002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767713002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767713002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767713002/60001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-03-05 03:06 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
Description was changed from ========== SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767713002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767713002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767713002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767713002/100001
lgtm until we can figure out what the issue with vc++ (from msvs 2013) is.
As a note to the future, explicitly deleting the SkData copy constructor works around the issues seen here. vc++ from msvs2015u1 seems to work with this fine.
Message was sent while issue was closed.
Description was changed from ========== SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SkPDF: PDFDevice use SkTArray<T> rather than SkTDArray<T*> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/91fcb3ed58845ddd5afa98a7150f3024d87c7425 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/91fcb3ed58845ddd5afa98a7150f3024d87c7425 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
