Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1767693002: Revert of PlzNavigate: inform the WebFrameClient that a form will be submitted (Closed)

Created:
4 years, 9 months ago by nasko
Modified:
4 years, 9 months ago
Reviewers:
clamy, Nate Chapin, dcheng
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, gavinp+loader_chromium.org, jam, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PlzNavigate: inform the WebFrameClient that a form will be submitted (patchset #4 id:60001 of https://codereview.chromium.org/1446253002/ ) Reason for revert: This is causing a bunch of crashes on Canary. Details are in https://crbug.com/591910. Original issue's description: > PlzNavigate: inform the WebFrameClient that a form will be submitted > > This CL makes it so that the WebFrameClient is informed that a form will be > submitted when the embedder handles the navigation. > > BUG=504347 > > Committed: https://crrev.com/bca103622d505bb537dbc2032de5fcd051c39e0d > Cr-Commit-Position: refs/heads/master@{#379001} TBR=dcheng@chromium.org,japhet@chromium.org,clamy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=504347 Committed: https://crrev.com/35fa1b226afdc5623af8389dc7454ac67eb2e62a Cr-Commit-Position: refs/heads/master@{#379353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -40 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +17 lines, -23 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 3 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
nasko
Created Revert of PlzNavigate: inform the WebFrameClient that a form will be submitted
4 years, 9 months ago (2016-03-04 19:03:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767693002/1
4 years, 9 months ago (2016-03-04 19:03:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767693002/1
4 years, 9 months ago (2016-03-04 19:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767693002/1
4 years, 9 months ago (2016-03-04 20:01:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767693002/1
4 years, 9 months ago (2016-03-04 20:31:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 20:56:46 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 20:57:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35fa1b226afdc5623af8389dc7454ac67eb2e62a
Cr-Commit-Position: refs/heads/master@{#379353}

Powered by Google App Engine
This is Rietveld 408576698