Ignore backspace when appending to the filter string in SampleApp. Fixes a bug on Windows where the…

Ignore backspace when appending to the filter string in SampleApp. Fixes a bug on Windows where the initial Backspace gets appended, causing no slides to match.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767683002

Committed: https://skia.googlesource.com/skia/+/fd95789e4993a28acb9054e6278d114a419d48ce

[Brian Osman, 2016-03-04 16:40:22]

Description was changed from

==========
Ignore backspace when appending to the filter string in SampleApp. Fixes a bug
on Windows where the initial Backspace gets appended, causing no slides to
match.

BUG=skia:
==========

to

==========
Ignore backspace when appending to the filter string in SampleApp. Fixes a bug
on Windows where the initial Backspace gets appended, causing no slides to
match.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-03-04 16:43:15]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, halcanary@google.com

[bsalomon, 2016-03-04 16:56:45]

lgtm

[hal.canary, 2016-03-04 16:57:30]

https://codereview.chromium.org/1767683002/diff/1/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/1767683002/diff/1/samplecode/OverView.cpp#new...
samplecode/OverView.cpp:62: if (uni != '\b') {
Why not 
    if (uni >= ' ') { ...

[Brian Osman, 2016-03-04 19:37:30]

Ignore all unprintable characters...

[Brian Osman, 2016-03-04 19:37:35]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-03-04 19:37:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1767683002/#ps20001
(title: "Ignore *all* unprintable characters")

[commit-bot: I haz the power, 2016-03-04 19:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767683002/20001

[commit-bot: I haz the power, 2016-03-04 19:59:29]

Description was changed from

==========
Ignore backspace when appending to the filter string in SampleApp. Fixes a bug
on Windows where the initial Backspace gets appended, causing no slides to
match.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Ignore backspace when appending to the filter string in SampleApp. Fixes a bug
on Windows where the initial Backspace gets appended, causing no slides to
match.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/fd95789e4993a28acb9054e6278d114a419d48ce
==========

[commit-bot: I haz the power, 2016-03-04 19:59:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fd95789e4993a28acb9054e6278d114a419d48ce