Chromium Code Reviews
DescriptionRevert of Decouple Media Service (patchset #22 id:420001 of https://codereview.chromium.org/1736643005/ )
Reason for revert:
Likely causing Windows 8 Debug GPU FYI WebGL video test failures.
First failing build:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Debug%20%28NVIDIA%29/builds/11936
Regression range:
https://chromium.googlesource.com/chromium/src/+log/643dba13a5f5af08e4aed492eac3411495361360..dd0212bf1ded527ef727fe2f2647186b472c379e
Failing tests:
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8_red_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_half_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r32f_red_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8ui_red_integer_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8_rg_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_half_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg32f_rg_float
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8ui_rg_integer_unsigned_byte
WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rgb8_rgb_unsigned_byte
WebglConformance.conformance_extensions_oes_texture_float_with_video
WebglConformance.conformance_extensions_oes_texture_half_float_with_video
WebglConformance.conformance_textures_misc_texture_upload_size
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_byte
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_short_5_6_5
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_byte
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_4_4_4_4
WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_5_5_5_1
BUG=592015
Original issue's description:
> Decouple Media Service
>
> This CL moves media object creation IPCs into a separate
> MediaChannel object that lives above GpuChannel.
>
> content/gpu (or mus in the future) becomes the layer that
> lives above both gpu and media and glues the two together.
>
> This may not reflect what a hypothetical future mojo
> interface might look like. If we want to preserve the
> ordering guarantees we have now, media interfaces should be
> associated interfaces that branch off a gpu channel and its
> gpu interfaces. This seems to suggest that gpu should know
> about media or else there should exist a factory interface
> that glues both media and gpu as we have here.
>
> I don't want to block this CL on long term mojo interface
> discussions as any direction we choose is just a refactor
> away. Until then, in the interest of making forward
> progress, I'd like to assume there exists a layer above
> both media and gpu.
>
> Thoughts?
>
> BUG=586384
>
> Committed: https://crrev.com/028d76aa627788a7252fd6de39304f67e00837ab
> Cr-Commit-Position: refs/heads/master@{#379211}
TBR=dcheng@chromium.org,piman@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=586384
Committed: https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959
Cr-Commit-Position: refs/heads/master@{#379297}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|