Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1767673002: Revert of Decouple Media Service (Closed)

Created:
4 years, 9 months ago by Jamie Madill
Modified:
4 years, 9 months ago
Reviewers:
Fady Samuel, dcheng, piman
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Decouple Media Service (patchset #22 id:420001 of https://codereview.chromium.org/1736643005/ ) Reason for revert: Likely causing Windows 8 Debug GPU FYI WebGL video test failures. First failing build: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Debug%20%28NVIDIA%29/builds/11936 Regression range: https://chromium.googlesource.com/chromium/src/+log/643dba13a5f5af08e4aed492eac3411495361360..dd0212bf1ded527ef727fe2f2647186b472c379e Failing tests: WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8_red_unsigned_byte WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_half_float WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r16f_red_float WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r32f_red_float WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_r8ui_red_integer_unsigned_byte WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8_rg_unsigned_byte WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_half_float WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg16f_rg_float WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg32f_rg_float WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rg8ui_rg_integer_unsigned_byte WebglConformance.conformance2_textures_video_tex_image_and_sub_image_2d_with_video_rgb8_rgb_unsigned_byte WebglConformance.conformance_extensions_oes_texture_float_with_video WebglConformance.conformance_extensions_oes_texture_half_float_with_video WebglConformance.conformance_textures_misc_texture_upload_size WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_byte WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgb_rgb_unsigned_short_5_6_5 WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_byte WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_4_4_4_4 WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_rgba_rgba_unsigned_short_5_5_5_1 BUG=592015 Original issue's description: > Decouple Media Service > > This CL moves media object creation IPCs into a separate > MediaChannel object that lives above GpuChannel. > > content/gpu (or mus in the future) becomes the layer that > lives above both gpu and media and glues the two together. > > This may not reflect what a hypothetical future mojo > interface might look like. If we want to preserve the > ordering guarantees we have now, media interfaces should be > associated interfaces that branch off a gpu channel and its > gpu interfaces. This seems to suggest that gpu should know > about media or else there should exist a factory interface > that glues both media and gpu as we have here. > > I don't want to block this CL on long term mojo interface > discussions as any direction we choose is just a refactor > away. Until then, in the interest of making forward > progress, I'd like to assume there exists a layer above > both media and gpu. > > Thoughts? > > BUG=586384 > > Committed: https://crrev.com/028d76aa627788a7252fd6de39304f67e00837ab > Cr-Commit-Position: refs/heads/master@{#379211} TBR=dcheng@chromium.org,piman@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586384 Committed: https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959 Cr-Commit-Position: refs/heads/master@{#379297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -693 lines) Patch
M content/common/content_message_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_jpeg_decode_accelerator_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/gpu/client/gpu_video_encode_accelerator_host.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 7 chunks +7 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 7 chunks +31 lines, -12 lines 0 comments Download
M content/common/gpu/gpu_channel_manager_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 2 chunks +12 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 5 chunks +43 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +7 lines, -0 lines 0 comments Download
D content/common/gpu/media/create_video_encoder_params.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/common/gpu/media/create_video_encoder_params.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M content/common/gpu/media/gpu_jpeg_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/media/media_channel.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/common/gpu/media/media_channel.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D content/common/gpu/media/media_messages.h View 1 chunk +0 lines, -287 lines 0 comments Download
D content/common/gpu/media/media_messages.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/common/gpu/media/media_service.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/common/gpu/media/media_service.cc View 1 chunk +0 lines, -40 lines 0 comments Download
A content/common/gpu/media_messages.h View 1 chunk +273 lines, -0 lines 0 comments Download
A content/common/gpu/media_messages.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -8 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 5 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jamie Madill
Created Revert of Decouple Media Service
4 years, 9 months ago (2016-03-04 16:22:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767673002/1
4 years, 9 months ago (2016-03-04 16:22:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 16:23:17 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 16:25:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8bbe7a881d08b2ae03312c6f3165257e37fd959
Cr-Commit-Position: refs/heads/master@{#379297}

Powered by Google App Engine
This is Rietveld 408576698