Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1767663002: Revert of Reland "[api] Don't go to javascript to construct API functions" (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "[api] Don't go to javascript to construct API functions" (patchset #1 id:1 of https://codereview.chromium.org/1756973002/ ) Reason for revert: [Sheriff] Breaks blink tests. Please fix upstream first. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5125 Original issue's description: > Reland "[api] Don't go to javascript to construct API functions" > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/d5d4f0b80f585878130bffb40ff8e960646823d8 > Cr-Commit-Position: refs/heads/master@{#34496} TBR=verwaest@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/12b196490f970abc05b3b495a4fa1444c81c0ce0 Cr-Commit-Position: refs/heads/master@{#34502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -67 lines) Patch
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/execution.cc View 2 chunks +29 lines, -39 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Reland "[api] Don't go to javascript to construct API functions"
4 years, 9 months ago (2016-03-04 15:54:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767663002/1
4 years, 9 months ago (2016-03-04 15:54:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 15:55:06 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 15:55:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12b196490f970abc05b3b495a4fa1444c81c0ce0
Cr-Commit-Position: refs/heads/master@{#34502}

Powered by Google App Engine
This is Rietveld 408576698