Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 176763011: Revert "Consider text alignment and direction when computing the left offset for horizontal writing… (Closed)

Created:
6 years, 9 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 9 months ago
Reviewers:
haraken, eae
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Consider text alignment and direction when computing the left offset for horizontal writing modes." This caused layout to fail in the filmstrip for Google Hangouts. This reverts r167732 and r168295. Landing with NOTRY=true because bots167732 seem busted. BUG=347889, 157539 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168527

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -300 lines) Patch
D LayoutTests/fast/css/text-align-positioned-inside-table-cell.html View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/platform/linux/fast/css/text-align-positioned-inside-table-cell-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/css/text-align-positioned-inside-table-cell-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/css/text-align-positioned-inside-table-cell-expected.txt View 1 chunk +0 lines, -90 lines 0 comments Download
D LayoutTests/platform/win/fast/css/text-align-positioned-inside-table-cell-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/css/text-align-positioned-inside-table-cell-expected.txt View 1 chunk +0 lines, -90 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 2 chunks +22 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -13 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
vrk (LEFT CHROMIUM)
6 years, 9 months ago (2014-03-04 02:42:45 UTC) #1
haraken
rubberstamp LGTM
6 years, 9 months ago (2014-03-04 03:18:28 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-04 03:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/176763011/1
6 years, 9 months ago (2014-03-04 03:18:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 20:57:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25684
6 years, 9 months ago (2014-03-04 20:57:07 UTC) #6
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 9 months ago (2014-03-04 20:59:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/176763011/1
6 years, 9 months ago (2014-03-04 20:59:48 UTC) #8
vrk (LEFT CHROMIUM)
The CQ bit was unchecked by vrk@chromium.org
6 years, 9 months ago (2014-03-05 00:08:49 UTC) #9
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 9 months ago (2014-03-05 00:09:13 UTC) #10
mario.prada
The failure from the win_blink_rel bot seems unrelated. Perhaps it would be better to try ...
6 years, 9 months ago (2014-03-05 09:37:14 UTC) #11
vrk (LEFT CHROMIUM)
The CQ bit was unchecked by vrk@chromium.org
6 years, 9 months ago (2014-03-05 20:17:32 UTC) #12
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 9 months ago (2014-03-05 20:36:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/176763011/1
6 years, 9 months ago (2014-03-05 20:36:15 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 20:37:18 UTC) #15
Message was sent while issue was closed. 
Change committed as 168527

Powered by Google App Engine
This is Rietveld 408576698