Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 176763009: Have DOMWindow deal with references instead of pointers when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 176763009: Have DOMWindow deal with references instead of pointers when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientationController.cpp b/Source/modules/screen_orientation/ScreenOrientationController.cpp

index c3f9974088792d15d72323d61227ca46cf994e01..e18f68a29ba3bab4980a09de40b7ecc0e288b589 100644

--- a/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -38,10 +38,10 @@ ScreenOrientationController::ScreenOrientationController(Document& document)

void ScreenOrientationController::dispatchOrientationChangeEvent()

{

- if (m_document.domWindow() && m_document.domWindow()->screen()

+ if (m_document.domWindow()

&& !m_document.activeDOMObjectsAreSuspended()

&& !m_document.activeDOMObjectsAreStopped())

- m_document.domWindow()->screen()->dispatchEvent(Event::create(EventTypeNames::orientationchange));

+ m_document.domWindow()->screen().dispatchEvent(Event::create(EventTypeNames::orientationchange));

}

const char* ScreenOrientationController::supplementName()