Source/core/page/CreateWindow.h - Issue 176763009: Have DOMWindow deal with references instead of pointers when possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/CreateWindow.h

Issue 176763009: Have DOMWindow deal with references instead of pointers when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/CreateWindow.h

diff --git a/Source/core/page/CreateWindow.h b/Source/core/page/CreateWindow.h

index 62b2ca7e5623a9b2101c6799d96dbbbc1aaa27cf..02494914ac154bdbc474828e6a7ca80261205f5c 100644

--- a/Source/core/page/CreateWindow.h

+++ b/Source/core/page/CreateWindow.h

@@ -38,9 +38,9 @@ struct FrameLoadRequest;

struct WindowFeatures;

LocalFrame* createWindow(const String& urlString, const AtomicString& frameName, const WindowFeatures&,

- DOMWindow* callingWindow, LocalFrame* firstFrame, LocalFrame* openerFrame);

+ DOMWindow& callingWindow, LocalFrame& firstFrame, LocalFrame& openerFrame);

-void createWindowForRequest(const FrameLoadRequest&, LocalFrame* openerFrame, NavigationPolicy, ShouldSendReferrer);

+void createWindowForRequest(const FrameLoadRequest&, LocalFrame& openerFrame, NavigationPolicy, ShouldSendReferrer);

} // namespace WebCore

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »