Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: Source/bindings/scripts/v8_callback_interface.py

Issue 176763009: Have DOMWindow deal with references instead of pointers when possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 CALLBACK_INTERFACE_H_INCLUDES = frozenset([ 42 CALLBACK_INTERFACE_H_INCLUDES = frozenset([
43 'bindings/v8/ActiveDOMCallback.h', 43 'bindings/v8/ActiveDOMCallback.h',
44 'bindings/v8/DOMWrapperWorld.h', 44 'bindings/v8/DOMWrapperWorld.h',
45 'bindings/v8/ScopedPersistent.h', 45 'bindings/v8/ScopedPersistent.h',
46 ]) 46 ])
47 CALLBACK_INTERFACE_CPP_INCLUDES = frozenset([ 47 CALLBACK_INTERFACE_CPP_INCLUDES = frozenset([
48 'bindings/v8/V8Binding.h', 48 'bindings/v8/V8Binding.h',
49 'bindings/v8/V8Callback.h', 49 'bindings/v8/V8Callback.h',
50 'core/dom/ExecutionContext.h', 50 'core/dom/ExecutionContext.h',
51 'wtf/Assertions.h', 51 'wtf/Assertions.h',
52 'wtf/GetPtr.h', # FIXME: remove if can eliminate WTF::getPtr 52 'wtf/GetPtr.h',
53 'wtf/RefPtr.h', 53 'wtf/RefPtr.h',
54 ]) 54 ])
55 55
56 56
57 def cpp_to_v8_conversion(idl_type, name): 57 def cpp_to_v8_conversion(idl_type, name):
58 # FIXME: setting creation_context=v8::Handle<v8::Object>() is wrong, 58 # FIXME: setting creation_context=v8::Handle<v8::Object>() is wrong,
59 # as toV8 then implicitly uses the current context, which causes leaks 59 # as toV8 then implicitly uses the current context, which causes leaks
60 # between isolate worlds if a different context should be used. 60 # between isolate worlds if a different context should be used.
61 cpp_value_to_v8_value = v8_types.cpp_value_to_v8_value(idl_type, name, 61 cpp_value_to_v8_value = v8_types.cpp_value_to_v8_value(idl_type, name,
62 isolate='m_isolate', creation_context='v8::Handle<v8::Object>()') 62 isolate='m_isolate', creation_context='v8::Handle<v8::Object>()')
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 argument_declarations = [ 132 argument_declarations = [
133 '%s %s' % (cpp_type(argument.idl_type), argument.name) 133 '%s %s' % (cpp_type(argument.idl_type), argument.name)
134 for argument in arguments] 134 for argument in arguments]
135 if call_with_this_handle: 135 if call_with_this_handle:
136 argument_declarations.insert(0, 'ScriptValue thisValue') 136 argument_declarations.insert(0, 'ScriptValue thisValue')
137 return { 137 return {
138 'argument_declarations': argument_declarations, 138 'argument_declarations': argument_declarations,
139 'arguments': [generate_argument(argument) for argument in arguments], 139 'arguments': [generate_argument(argument) for argument in arguments],
140 'handles': ['%sHandle' % argument.name for argument in arguments], 140 'handles': ['%sHandle' % argument.name for argument in arguments],
141 } 141 }
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698