Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1767543002: Use c:\goma\goma-win64 as default gomadir on Windows. (Closed)

Created:
4 years, 9 months ago by Yoshisato Yanagisawa
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use c:\goma\goma-win64 as default gomadir on Windows. 32bit goma client has already been deprecated. Let me make c:\goma\goma-win64 as the default gomadir on Windows. Committed: https://crrev.com/32f0fcc3c09e6531ae83d3ce1fc8dd66fd6db82f Cr-Commit-Position: refs/heads/master@{#379517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/goma.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Yoshisato Yanagisawa
Hi, Since we have already deprecated 32bit Windows goma client, let me change the default ...
4 years, 9 months ago (2016-03-04 01:49:34 UTC) #2
brettw
lgtm
4 years, 9 months ago (2016-03-04 20:36:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767543002/1
4 years, 9 months ago (2016-03-07 01:51:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/178578)
4 years, 9 months ago (2016-03-07 03:44:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767543002/1
4 years, 9 months ago (2016-03-07 05:55:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 06:38:51 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 06:39:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32f0fcc3c09e6531ae83d3ce1fc8dd66fd6db82f
Cr-Commit-Position: refs/heads/master@{#379517}

Powered by Google App Engine
This is Rietveld 408576698