Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: runtime/vm/code_generator.cc

Issue 17675002: Correctly deal with method invocation of a getter. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/method_invocation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 24455)
+++ runtime/vm/code_generator.cc (working copy)
@@ -1169,13 +1169,10 @@
args.SetAt(0, receiver);
const Object& value = Object::Handle(DartEntry::InvokeFunction(getter, args));
- // 3. If the getter threw an exception, treat it as no such method.
- if (value.IsUnhandledException()) return false;
-
- // 4. If there was some other error, propagate it.
+ // 3. If there was some error, propagate it.
CheckResultError(value);
- // 5. Invoke the value as a closure.
+ // 4. Invoke the value as a closure.
Instance& instance = Instance::Handle();
instance ^= value.raw();
arguments.SetAt(0, instance);
« no previous file with comments | « no previous file | tests/language/method_invocation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698