Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: tools/perf/page_sets/typical_25.py

Issue 1767413002: [Telemetry] Cleanup some unused variables in page_sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/tough_pinch_zoom_cases.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import shutil 5 import shutil
6 6
7 from profile_creators import profile_generator 7 from profile_creators import profile_generator
8 from profile_creators import small_profile_extender 8 from profile_creators import small_profile_extender
9 from telemetry.page import page as page_module 9 from telemetry.page import page as page_module
10 from telemetry.page import shared_page_state 10 from telemetry.page import shared_page_state
(...skipping 25 matching lines...) Expand all
36 shutil.rmtree(self._out_dir) 36 shutil.rmtree(self._out_dir)
37 37
38 38
39 class Typical25Page(page_module.Page): 39 class Typical25Page(page_module.Page):
40 40
41 def __init__(self, url, page_set, run_no_page_interactions, 41 def __init__(self, url, page_set, run_no_page_interactions,
42 shared_page_state_class=shared_page_state.SharedDesktopPageState): 42 shared_page_state_class=shared_page_state.SharedDesktopPageState):
43 super(Typical25Page, self).__init__( 43 super(Typical25Page, self).__init__(
44 url=url, page_set=page_set, 44 url=url, page_set=page_set,
45 shared_page_state_class=shared_page_state_class) 45 shared_page_state_class=shared_page_state_class)
46 self.archive_data_file = 'data/typical_25.json'
47 self._run_no_page_interactions = run_no_page_interactions 46 self._run_no_page_interactions = run_no_page_interactions
48 47
49 def RunPageInteractions(self, action_runner): 48 def RunPageInteractions(self, action_runner):
50 if self._run_no_page_interactions: 49 if self._run_no_page_interactions:
51 return 50 return
52 with action_runner.CreateGestureInteraction('ScrollAction'): 51 with action_runner.CreateGestureInteraction('ScrollAction'):
53 action_runner.ScrollPage() 52 action_runner.ScrollPage()
54 53
55 54
56 class Typical25PageSet(story.StorySet): 55 class Typical25PageSet(story.StorySet):
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 'http://www.theverge.com/2013/3/5/4061684/inside-ted-the-smartest-bubble-i n-the-world', 99 'http://www.theverge.com/2013/3/5/4061684/inside-ted-the-smartest-bubble-i n-the-world',
101 'http://www.airbnb.com/', 100 'http://www.airbnb.com/',
102 'http://www.ign.com/', 101 'http://www.ign.com/',
103 # Why: Alexa health #25 102 # Why: Alexa health #25
104 'http://www.fda.gov', 103 'http://www.fda.gov',
105 ] 104 ]
106 105
107 for url in urls_list: 106 for url in urls_list:
108 self.AddStory( 107 self.AddStory(
109 page_class(url, self, run_no_page_interactions)) 108 page_class(url, self, run_no_page_interactions))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/tough_pinch_zoom_cases.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698