Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: tools/perf/page_sets/top_25_repaint.py

Issue 1767413002: [Telemetry] Cleanup some unused variables in page_sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import shared_page_state 5 from telemetry.page import shared_page_state
6 from telemetry import story 6 from telemetry import story
7 7
8 from page_sets import repaint_helpers 8 from page_sets import repaint_helpers
9 from page_sets import top_pages 9 from page_sets import top_pages
10 10
11 11
12 class TopRepaintPage(page_module.Page): 12 class TopRepaintPage(page_module.Page):
13 13
14 def __init__(self, url, page_set, mode, width, height, name='', 14 def __init__(self, url, page_set, mode, width, height, name=''):
15 credentials=None):
16 super(TopRepaintPage, self).__init__( 15 super(TopRepaintPage, self).__init__(
17 url=url, page_set=page_set, name=name, 16 url=url, page_set=page_set, name=name,
18 credentials_path='data/credentials.json', 17 credentials_path='data/credentials.json',
19 shared_page_state_class=shared_page_state.SharedDesktopPageState) 18 shared_page_state_class=shared_page_state.SharedDesktopPageState)
20 self.archive_data_file = 'data/top_25_repaint.json'
21 self.credentials = credentials
22 self._mode = mode 19 self._mode = mode
23 self._width = width 20 self._width = width
24 self._height = height 21 self._height = height
25 22
26 def RunPageInteractions(self, action_runner): 23 def RunPageInteractions(self, action_runner):
27 repaint_helpers.Repaint( 24 repaint_helpers.Repaint(
28 action_runner, mode=self._mode, width=self._width, height=self._height) 25 action_runner, mode=self._mode, width=self._width, height=self._height)
29 26
30 27
31 def _CreatePageClassWithRepaintInteractions(page_cls, mode, width, height): 28 def _CreatePageClassWithRepaintInteractions(page_cls, mode, width, height):
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 'http://answers.yahoo.com', 85 'http://answers.yahoo.com',
89 # Why: #1 Alexa sports 86 # Why: #1 Alexa sports
90 'http://sports.yahoo.com/', 87 'http://sports.yahoo.com/',
91 # Why: top tech blog 88 # Why: top tech blog
92 'http://techcrunch.com' 89 'http://techcrunch.com'
93 ] 90 ]
94 91
95 for url in other_urls: 92 for url in other_urls:
96 self.AddStory( 93 self.AddStory(
97 TopRepaintPage(url, self, mode=mode, height=height, width=width)) 94 TopRepaintPage(url, self, mode=mode, height=height, width=width))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/simple_mobile_sites.py ('k') | tools/perf/page_sets/tough_pinch_zoom_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698