Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: tools/perf/page_sets/intl_ja_zh.py

Issue 1767413002: [Telemetry] Cleanup some unused variables in page_sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/google_pages.py ('k') | tools/perf/page_sets/intl_ko_th_vi.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import shared_page_state 5 from telemetry.page import shared_page_state
6 from telemetry import story 6 from telemetry import story
7 7
8 8
9 class IntlJaZhPage(page_module.Page): 9 class IntlJaZhPage(page_module.Page):
10 10
11 def __init__(self, url, page_set): 11 def __init__(self, url, page_set):
12 super(IntlJaZhPage, self).__init__( 12 super(IntlJaZhPage, self).__init__(
13 url=url, page_set=page_set, 13 url=url, page_set=page_set,
14 shared_page_state_class=shared_page_state.SharedDesktopPageState) 14 shared_page_state_class=shared_page_state.SharedDesktopPageState)
15 self.archive_data_file = 'data/intl_ja_zh.json'
16 15
17 16
18 class IntlJaZhPageSet(story.StorySet): 17 class IntlJaZhPageSet(story.StorySet):
19 18
20 """ Popular pages in Japanese and Chinese. """ 19 """ Popular pages in Japanese and Chinese. """
21 20
22 def __init__(self): 21 def __init__(self):
23 super(IntlJaZhPageSet, self).__init__( 22 super(IntlJaZhPageSet, self).__init__(
24 archive_data_file='data/intl_ja_zh.json', 23 archive_data_file='data/intl_ja_zh.json',
25 cloud_storage_bucket=story.PARTNER_BUCKET) 24 cloud_storage_bucket=story.PARTNER_BUCKET)
(...skipping 24 matching lines...) Expand all
50 'http://www.sina.com.cn/', 49 'http://www.sina.com.cn/',
51 # Why: #5 Chinese site 50 # Why: #5 Chinese site
52 # pylint: disable=line-too-long 51 # pylint: disable=line-too-long
53 'http://www.google.com.hk/#q=%E9%82%84%E6%8F%90%E4%BE%9B&fp=c44d333e710cb4 80', 52 'http://www.google.com.hk/#q=%E9%82%84%E6%8F%90%E4%BE%9B&fp=c44d333e710cb4 80',
54 'http://udn.com/NEWS/mainpage.shtml', 53 'http://udn.com/NEWS/mainpage.shtml',
55 'http://ruten.com.tw/' 54 'http://ruten.com.tw/'
56 ] 55 ]
57 56
58 for url in urls_list: 57 for url in urls_list:
59 self.AddStory(IntlJaZhPage(url, self)) 58 self.AddStory(IntlJaZhPage(url, self))
OLDNEW
« no previous file with comments | « tools/perf/page_sets/google_pages.py ('k') | tools/perf/page_sets/intl_ko_th_vi.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698