Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 17674003: Support both SharedWorkerContext and SharedWorkerGlobalScope to detect shared worker context (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org, lgombos
Visibility:
Public.

Description

Support both SharedWorkerContext and SharedWorkerGlobalScope to detect shared worker context Update metadata_dispatcher.js to support both SharedWorkerContext and SharedWorkerGlobalScope to detect shared worker context. The shared worker context was renamed to SharedWorkerGlobalScope in the latest specification and the interface is going to be renamed in Blink soon. R=arv BUG=253473 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208533

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-25 14:57:36 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/17674003/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js File chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js (right): https://codereview.chromium.org/17674003/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js#newcode217 chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js:217: // TODO(cdumez) Remove support for SharedWorkerContext name after ...
7 years, 6 months ago (2013-06-25 15:35:15 UTC) #2
do-not-use
https://codereview.chromium.org/17674003/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js File chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js (right): https://codereview.chromium.org/17674003/diff/1/chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js#newcode217 chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js:217: // TODO(cdumez) Remove support for SharedWorkerContext name after Blink ...
7 years, 6 months ago (2013-06-25 15:41:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17674003/11001
7 years, 6 months ago (2013-06-25 15:43:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=169095
7 years, 6 months ago (2013-06-25 18:01:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17674003/11001
7 years, 6 months ago (2013-06-25 18:53:34 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 18:53:50 UTC) #7
Message was sent while issue was closed.
Change committed as 208533

Powered by Google App Engine
This is Rietveld 408576698