Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1767393002: Allow overriding -fno-gnu-inline-assembly (Closed)

Created:
4 years, 9 months ago by Petr Hosek
Modified:
4 years, 9 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-clang.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow overriding -fno-gnu-inline-assembly While -fno-gnu-inline-assembly is default, in some cases we need want override the option and explicitly enable inline assembly. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347 R=dschuff@chromium.org Committed: 6836bf546dcd883aef4e53ee881d666410bf3e71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/Driver/Tools.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Petr Hosek
4 years, 9 months ago (2016-03-08 01:51:09 UTC) #1
Mark Seaborn
Should this have BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4347?
4 years, 9 months ago (2016-03-08 15:42:45 UTC) #2
Derek Schuff
lgtm
4 years, 9 months ago (2016-03-08 18:01:34 UTC) #3
Petr Hosek
4 years, 9 months ago (2016-03-08 18:16:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6836bf546dcd883aef4e53ee881d666410bf3e71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698