chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 1767343004: Replace base::Tuple in //chrome with std::tuple

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 1767343004: Replace base::Tuple in //chrome with std::tuple (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | chrome/browser/search/instant_service_unittest.cc » ('j') | chrome/renderer/autofill/autofill_renderer_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

index 0438fd75e6dce1d088a47d4ba354ac8d670f5cc9..f025b295859823dee2aacaf73cf34f823e37e9de 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/safe_browsing/client_side_detection_host.h"

+#include <tuple>

#include <utility>

#include "base/files/file_path.h"

@@ -329,9 +330,9 @@ class ClientSideDetectionHostTest : public ChromeRenderViewHostTestHarness {

SafeBrowsingMsg_StartPhishingDetection::ID);

if (url) {

ASSERT_TRUE(msg);

- base::Tuple<GURL> actual_url;

+ std::tuple<GURL> actual_url;

SafeBrowsingMsg_StartPhishingDetection::Read(msg, &actual_url);

- EXPECT_EQ(*url, base::get<0>(actual_url));

+ EXPECT_EQ(*url, std::get<0>(actual_url));

EXPECT_EQ(main_rfh()->GetRoutingID(), msg->routing_id());

process()->sink().ClearMessages();

} else {