Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1767343004: Replace base::Tuple in //chrome with std::tuple (Closed)

Created:
4 years, 9 months ago by tzik
Modified:
4 years, 9 months ago
CC:
bondd+autofillwatch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj, darin-cc_chromium.org, davidben+watch_chromium.org, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, gavinp+prer_chromium.org, gcasto+watchlist_chromium.org, groby+spellwatch_chromium.org, grt+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, Matt Giuca, mkwst+watchlist-passwords_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, rouslan+autofill_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, tapted, tburkard+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace base::Tuple in //chrome with std::tuple BUG=554987 Committed: https://crrev.com/c2209d64691b2c3495fd7c07a8d6d3306e6238e8 Cr-Commit-Position: refs/heads/master@{#380085}

Patch Set 1 #

Total comments: 4

Patch Set 2 : s/typedef/using/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -102 lines) Patch
M chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/search/instant_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 1 7 chunks +9 lines, -7 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 8 chunks +19 lines, -17 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/renderer/translate/translate_helper_browsertest.cc View 14 chunks +18 lines, -16 lines 0 comments Download
M chrome/utility/shell_handler_win.h View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767343004/1
4 years, 9 months ago (2016-03-08 09:24:54 UTC) #2
tzik
PTAL
4 years, 9 months ago (2016-03-08 09:35:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 10:10:13 UTC) #8
tzik
jochen: Please take a look as a //chrome owner.
4 years, 9 months ago (2016-03-08 13:34:16 UTC) #10
tzik
+dcheng. Could you take a look to //chrome/common/chrome_utility_messages.h ?
4 years, 9 months ago (2016-03-08 13:38:26 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-08 15:59:36 UTC) #13
dcheng
ipc rs lgtm
4 years, 9 months ago (2016-03-08 18:07:32 UTC) #14
danakj
LGTM https://codereview.chromium.org/1767343004/diff/1/chrome/renderer/autofill/autofill_renderer_browsertest.cc File chrome/renderer/autofill/autofill_renderer_browsertest.cc (right): https://codereview.chromium.org/1767343004/diff/1/chrome/renderer/autofill/autofill_renderer_browsertest.cc#newcode43 chrome/renderer/autofill/autofill_renderer_browsertest.cc:43: typedef std::tuple<int, autofill::FormData, autofill::FormFieldData, nit: using https://codereview.chromium.org/1767343004/diff/1/chrome/utility/shell_handler_win.h File ...
4 years, 9 months ago (2016-03-08 18:22:25 UTC) #16
tzik
https://codereview.chromium.org/1767343004/diff/1/chrome/renderer/autofill/autofill_renderer_browsertest.cc File chrome/renderer/autofill/autofill_renderer_browsertest.cc (right): https://codereview.chromium.org/1767343004/diff/1/chrome/renderer/autofill/autofill_renderer_browsertest.cc#newcode43 chrome/renderer/autofill/autofill_renderer_browsertest.cc:43: typedef std::tuple<int, autofill::FormData, autofill::FormFieldData, On 2016/03/08 18:22:24, danakj wrote: ...
4 years, 9 months ago (2016-03-09 05:26:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767343004/20001
4 years, 9 months ago (2016-03-09 05:27:39 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 06:30:31 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 06:32:00 UTC) #24
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c2209d64691b2c3495fd7c07a8d6d3306e6238e8
Cr-Commit-Position: refs/heads/master@{#380085}

Powered by Google App Engine
This is Rietveld 408576698