Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1767343003: X87: [crankshaft] Support ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Support ES6 tail call elimination. port 22938040fdb9a061babe96f004355fd79b2958a0 (r34542) original commit message: HInvokeFunction and HApplyArguments instructions now support tail calling. Inlining of calls at tail position is not supported yet and therefore still disabled. The tail-call-megatest was modified so that the usages of "arguments" object do not disable Crankshaft. BUG= Committed: https://crrev.com/802a906ed02500da4537c1755d7b2d0f592f49c4 Cr-Commit-Position: refs/heads/master@{#34590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -78 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 4 chunks +101 lines, -20 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +10 lines, -50 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 3 chunks +12 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-08 07:13:36 UTC) #2
Igor Sheludko
lgtm
4 years, 9 months ago (2016-03-08 07:51:21 UTC) #3
Weiliang
lgtm
4 years, 9 months ago (2016-03-08 13:45:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767343003/1
4 years, 9 months ago (2016-03-08 14:42:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 15:00:29 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 15:01:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/802a906ed02500da4537c1755d7b2d0f592f49c4
Cr-Commit-Position: refs/heads/master@{#34590}

Powered by Google App Engine
This is Rietveld 408576698