Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1767343002: DevTools: [regression] do not go back and forth via utf8 in the debugger/runtime agents. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [regression] do not go back and forth via utf8 in the debugger/runtime agents. BUG=592820 NOTRY=true Committed: https://crrev.com/0599b75469cb6edec440ec4c6ec1f3bc29b383f6 Cr-Commit-Position: refs/heads/master@{#379716}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
pfeldman
4 years, 9 months ago (2016-03-08 00:42:13 UTC) #2
dgozman
lgtm
4 years, 9 months ago (2016-03-08 00:50:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767343002/20001
4 years, 9 months ago (2016-03-08 00:51:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/179148)
4 years, 9 months ago (2016-03-08 01:21:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767343002/40001
4 years, 9 months ago (2016-03-08 02:05:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767343002/40001
4 years, 9 months ago (2016-03-08 03:28:49 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 03:34:09 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 03:35:30 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0599b75469cb6edec440ec4c6ec1f3bc29b383f6
Cr-Commit-Position: refs/heads/master@{#379716}

Powered by Google App Engine
This is Rietveld 408576698