Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1767263002: Suppress C4201 for Windows build. (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress C4201 for Windows build. warning C4201: nonstandard extension used : nameless struct/union R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b90dabecdb9a8a439265e327b7f0f770d9a5245c

Patch Set 1 #

Patch Set 2 : disable for GYP as well to keep things consistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Oliver Chang
4 years, 9 months ago (2016-03-07 22:38:45 UTC) #1
Oliver Chang
(see https://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/113914/steps/compile%20%28with%20patch%29/logs/stdio )
4 years, 9 months ago (2016-03-07 22:39:15 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-07 22:44:28 UTC) #4
Oliver Chang
4 years, 9 months ago (2016-03-07 22:45:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b90dabecdb9a8a439265e327b7f0f770d9a5245c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698