Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1767233002: Update to use absolute path in instruction comments. (Closed)

Created:
4 years, 9 months ago by Jess
Modified:
4 years, 9 months ago
Reviewers:
*Dirk Pranke
CC:
chromium-reviews, nyquist, maniscalco
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update to use absolute path in instruction comments. Currently the comments in the template use a relative path. Switching to an absolute path brings the comments in line with the blimp build docs and makes usage more robust. BUG= Committed: https://crrev.com/6f6fad43de425bca8c4178b95a9f1a5806ae6a2d Cr-Commit-Position: refs/heads/master@{#379705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/args/blimp_client.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/args/blimp_engine.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Jess
Thank you for noticing this and bringing it to my attention.
4 years, 9 months ago (2016-03-07 22:06:28 UTC) #3
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-08 01:47:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767233002/1
4 years, 9 months ago (2016-03-08 01:56:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 02:34:03 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 02:35:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f6fad43de425bca8c4178b95a9f1a5806ae6a2d
Cr-Commit-Position: refs/heads/master@{#379705}

Powered by Google App Engine
This is Rietveld 408576698