Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1767203002: [wasm] Allow Uint8Array in _WASMEXP_.instantiateModule() (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
Derek Schuff
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Allow Uint8Array in _WASMEXP_.instantiateModule() R=dschuff@chromium.org BUG= Committed: https://crrev.com/56157fe819b7bb4fc6e5cedf1d0bf20ae5c6ebc2 Cr-Commit-Position: refs/heads/master@{#34565}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M src/wasm/wasm-js.cc View 1 2 1 chunk +31 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 9 months ago (2016-03-07 20:32:34 UTC) #1
Derek Schuff
otherwise LGTM https://codereview.chromium.org/1767203002/diff/1/src/wasm/wasm-js.cc File src/wasm/wasm-js.cc (right): https://codereview.chromium.org/1767203002/diff/1/src/wasm/wasm-js.cc#newcode56 src/wasm/wasm-js.cc:56: if (start == nullptr) { should we ...
4 years, 9 months ago (2016-03-07 20:37:18 UTC) #2
titzer
https://codereview.chromium.org/1767203002/diff/1/src/wasm/wasm-js.cc File src/wasm/wasm-js.cc (right): https://codereview.chromium.org/1767203002/diff/1/src/wasm/wasm-js.cc#newcode56 src/wasm/wasm-js.cc:56: if (start == nullptr) { On 2016/03/07 20:37:17, Derek ...
4 years, 9 months ago (2016-03-07 20:39:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767203002/40001
4 years, 9 months ago (2016-03-07 20:51:44 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 21:09:26 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 21:10:04 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/56157fe819b7bb4fc6e5cedf1d0bf20ae5c6ebc2
Cr-Commit-Position: refs/heads/master@{#34565}

Powered by Google App Engine
This is Rietveld 408576698