Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1767173002: PPC: [crankshaft] Support ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [crankshaft] Support ES6 tail call elimination. Port 22938040fdb9a061babe96f004355fd79b2958a0 Original commit message: HInvokeFunction and HApplyArguments instructions now support tail calling. Inlining of calls at tail position is not supported yet and therefore still disabled. The tail-call-megatest was modified so that the usages of "arguments" object do not disable Crankshaft. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Committed: https://crrev.com/826f67bec35e1e2def0650dfa443f2534589f7a3 Cr-Commit-Position: refs/heads/master@{#34563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -70 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 4 chunks +92 lines, -16 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 3 chunks +11 lines, -47 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +9 lines, -6 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-07 20:13:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767173002/1
4 years, 9 months ago (2016-03-07 20:13:35 UTC) #3
michael_dawson
On 2016/03/07 20:13:35, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-07 20:20:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 20:36:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767173002/1
4 years, 9 months ago (2016-03-07 20:46:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 20:55:09 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 20:55:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/826f67bec35e1e2def0650dfa443f2534589f7a3
Cr-Commit-Position: refs/heads/master@{#34563}

Powered by Google App Engine
This is Rietveld 408576698