Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1767163002: Reland of Avoid nuking everything when injecting stylesheet. (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
Reviewers:
dstockwell, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1 of https://codereview.chromium.org/1770903002/ ) Reason for revert: Relanding since the original CL doesn't seem to be the cause of the flakiness. Original issue's description: > Revert of Avoid nuking everything when injecting stylesheet. (patchset #1 id:1 of https://codereview.chromium.org/1762443004/ ) > > Reason for revert: > Seems to have introduced a (slightly flaky) use-after-free on Mac ASan 64: > https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29?numbuilds=100 > > "All_ParameterizedWebFrameTest.SetForceZeroLayoutHeightWorksAcrossNavigations_1" fails pretty consistently (only 1 success out of ~20 runs), a few others fail only occasionally. > > Original issue's description: > > Avoid nuking everything when injecting stylesheet. > > > > Instead do an analyzed update of the Document scope. > > > > Committed: https://crrev.com/6ddb19de461880fa47a5c563f30119e6d05b20be > > Cr-Commit-Position: refs/heads/master@{#379528} > > TBR=dstockwell@chromium.org,rune@opera.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/3b2214c75296d5ee376f7a3853af14ab7aafb98d > Cr-Commit-Position: refs/heads/master@{#379580} TBR=dstockwell@chromium.org,rune@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/701f238b27019e76f57af621f52ad7f5a53456d3 Cr-Commit-Position: refs/heads/master@{#379615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Marc Treib
Created Reland of Avoid nuking everything when injecting stylesheet.
4 years, 9 months ago (2016-03-07 19:45:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767163002/1
4 years, 9 months ago (2016-03-07 19:46:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 19:47:04 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 19:50:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/701f238b27019e76f57af621f52ad7f5a53456d3
Cr-Commit-Position: refs/heads/master@{#379615}

Powered by Google App Engine
This is Rietveld 408576698