Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 176713008: Webkit: use fabs() for double (Closed)

Created:
6 years, 9 months ago by yunlian
Modified:
6 years, 9 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Webkit: use fabs() for double fabsf() is for float, use fabs() for double instead. BUG=chromium:348044 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168557

Patch Set 1 #

Patch Set 2 : Webkit: use fabs() for double #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/html/TimeRanges.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yunlian
6 years, 9 months ago (2014-03-03 23:04:10 UTC) #1
acolwell GONE FROM CHROMIUM
Please reupload the patch. It looks like the base files are missing.
6 years, 9 months ago (2014-03-03 23:54:35 UTC) #2
yunlian
On 2014/03/03 23:54:35, acolwell wrote: > Please reupload the patch. It looks like the base ...
6 years, 9 months ago (2014-03-04 00:07:33 UTC) #3
Peter Kasting
Removing myself as a reviewer. When you send reviews with multiple reviewers, please say explicitly ...
6 years, 9 months ago (2014-03-04 00:39:39 UTC) #4
acolwell GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-04 01:50:43 UTC) #5
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-04 01:51:02 UTC) #6
yunlian
The CQ bit was checked by yunlian@chromium.org
6 years, 9 months ago (2014-03-04 17:20:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/176713008/20001
6 years, 9 months ago (2014-03-04 17:20:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/176713008/20001
6 years, 9 months ago (2014-03-05 20:54:01 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 03:42:32 UTC) #10
Message was sent while issue was closed.
Change committed as 168557

Powered by Google App Engine
This is Rietveld 408576698