Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1767123002: [runtime] Pass in receiver as target to the LookupIterator if known to be JSReceiver (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Pass in receiver as target to the LookupIterator if known to be JSReceiver This avoids a minor unnecessary inefficiency (GetRoot) in setting up the LookupIterator. BUG= Committed: https://crrev.com/d117207a94a3a2e262c3c0cec53c78c6c5d4fea3 Cr-Commit-Position: refs/heads/master@{#34560}

Patch Set 1 #

Patch Set 2 : Also api.cc #

Patch Set 3 : object-inl #

Patch Set 4 : runtime-object.cc #

Patch Set 5 : builtins #

Patch Set 6 : contexts #

Patch Set 7 : runtime-scopes #

Patch Set 8 : property-descriptor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -56 lines) Patch
M src/api.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 6 chunks +10 lines, -9 lines 0 comments Download
M src/contexts.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 16 chunks +19 lines, -17 lines 0 comments Download
M src/objects-inl.h View 1 2 7 chunks +10 lines, -10 lines 0 comments Download
M src/property-descriptor.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 7 chunks +9 lines, -9 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 3 4 5 6 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-07 16:59:06 UTC) #2
Camillo Bruni
lgtm maybe extend the commit message to justify this optimization.
4 years, 9 months ago (2016-03-07 18:51:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767123002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767123002/140001
4 years, 9 months ago (2016-03-07 19:11:24 UTC) #6
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 9 months ago (2016-03-07 19:48:49 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 19:50:29 UTC) #10
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/d117207a94a3a2e262c3c0cec53c78c6c5d4fea3
Cr-Commit-Position: refs/heads/master@{#34560}

Powered by Google App Engine
This is Rietveld 408576698