Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1767113007: Fix crash when setting breakpoint in Observatory (Closed)

Created:
4 years, 9 months ago by hausner
Modified:
4 years, 9 months ago
Reviewers:
Cutch, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix crash when setting breakpoint in Observatory Fix bug in code that determines end token pos of classes, handle typedef classes correctly. BUG=25880 R=floitsch@google.com, johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5db2c56b5bb5c7e18146f11e2d4baf07e34d5fbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hausner
4 years, 9 months ago (2016-03-09 01:11:37 UTC) #3
floitsch
LGTM. No new test?
4 years, 9 months ago (2016-03-09 12:06:07 UTC) #5
Cutch
lgtm
4 years, 9 months ago (2016-03-09 16:52:17 UTC) #6
hausner
Committed patchset #1 (id:1) manually as 5db2c56b5bb5c7e18146f11e2d4baf07e34d5fbb (presubmit successful).
4 years, 9 months ago (2016-03-09 16:55:59 UTC) #8
hausner
4 years, 9 months ago (2016-03-09 16:56:48 UTC) #9
Message was sent while issue was closed.
Thank you. I think a test would be overkill here.

Powered by Google App Engine
This is Rietveld 408576698