Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: src/elements.h

Issue 1767113004: [esnext] handle elements in FastObjectValuesOrEntries() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make ElementsAccessor::GetCapacity() public, and use it Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index fcd273ebe7deca34a4d4632cbb40add68184626e..2b18ab07d12066cfb53fde8f8501b8698d6af752 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -95,6 +95,11 @@ class ElementsAccessor {
filter, offset);
}
+ virtual Maybe<bool> CollectValuesOrEntries(
+ Isolate* isolate, Handle<JSObject> object,
+ Handle<FixedArray> values_or_entries, bool get_entries, int* nof_items,
+ PropertyFilter filter = ALL_PROPERTIES) = 0;
+
//
virtual Handle<FixedArray> PrependElementIndices(
Handle<JSObject> object, Handle<FixedArrayBase> backing_store,
@@ -151,6 +156,9 @@ class ElementsAccessor {
virtual Handle<SeededNumberDictionary> Normalize(Handle<JSObject> object) = 0;
+ virtual uint32_t GetCapacity(JSObject* holder,
+ FixedArrayBase* backing_store) = 0;
+
protected:
friend class LookupIterator;
@@ -176,8 +184,6 @@ class ElementsAccessor {
uint32_t destination_start, int copy_size) = 0;
private:
- virtual uint32_t GetCapacity(JSObject* holder,
- FixedArrayBase* backing_store) = 0;
static ElementsAccessor** elements_accessors_;
const char* name_;
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698