Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1767063002: Fix completion value of empty catch block in the presence of destructuring. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix completion value of empty catch block in the presence of destructuring. R=adamk@chromium.org BUG= Committed: https://crrev.com/998a6e5b9254874b508356103358878ea7b2c257 Cr-Commit-Position: refs/heads/master@{#34575}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/parsing/parser.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
neis
4 years, 9 months ago (2016-03-07 12:40:56 UTC) #1
adamk
lgtm I never remember that bool arg is a double-negative. Really should change it to ...
4 years, 9 months ago (2016-03-07 18:03:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767063002/1
4 years, 9 months ago (2016-03-08 08:20:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/2522) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-08 08:34:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767063002/20001
4 years, 9 months ago (2016-03-08 09:13:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 09:35:16 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 09:36:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/998a6e5b9254874b508356103358878ea7b2c257
Cr-Commit-Position: refs/heads/master@{#34575}

Powered by Google App Engine
This is Rietveld 408576698