mojom/mojom_parser/parser/comment_merger_test.go - Issue 1767033002: Mojom parser: Compute and validate struct field ordinals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/parser/comment_merger_test.go

Issue 1767033002: Mojom parser: Compute and validate struct field ordinals. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Maintain the property that the fields of a module.Struct are sorted in declaration order. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojom/mojom_parser/parser/comment_merger_test.go

diff --git a/mojom/mojom_parser/parser/comment_merger_test.go b/mojom/mojom_parser/parser/comment_merger_test.go

index fdce0c012eae7bcefb474354139965cc43dd5eb2..45c75b3b1d02f73d544e508c5d4269e84dfd6791 100644

--- a/mojom/mojom_parser/parser/comment_merger_test.go

+++ b/mojom/mojom_parser/parser/comment_merger_test.go

@@ -66,7 +66,7 @@ func TestAttachComments(t *testing.T) {

// Sanity-check that we got the right method.

checkEq("Method1", method1.SimpleName())

- inParam1 := method1.Parameters.Fields[0]

+ inParam1 := method1.Parameters.FieldsInLexicalOrder[0]

// Sanity-check that we got the right field.

checkEq("in_param1", inParam1.SimpleName())