Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1766943002: Refators display related functionality into own class (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refators display related functionality into own class BUG=590955 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85 Cr-Commit-Position: refs/heads/master@{#379567}

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -249 lines) Patch
M components/mus/mus_app.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/mus_app.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/ws/connection_manager.h View 10 chunks +16 lines, -53 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 18 chunks +57 lines, -134 lines 0 comments Download
M components/mus/ws/connection_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/display.h View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M components/mus/ws/display.cc View 1 2 11 chunks +24 lines, -16 lines 0 comments Download
A components/mus/ws/display_manager.h View 1 chunk +90 lines, -0 lines 0 comments Download
A components/mus/ws/display_manager.cc View 1 chunk +128 lines, -0 lines 0 comments Download
A components/mus/ws/display_manager_delegate.h View 1 chunk +26 lines, -0 lines 0 comments Download
M components/mus/ws/display_unittest.cc View 1 2 5 chunks +12 lines, -9 lines 0 comments Download
M components/mus/ws/server_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/test_server_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/test_server_window_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/ws/test_utils.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/mus/ws/window_tree.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree.cc View 1 8 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 9 months ago (2016-03-05 18:36:01 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-05 19:06:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1766943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1766943002/40001
4 years, 9 months ago (2016-03-07 16:13:16 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-07 17:03:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 17:06:15 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3bddcde6d2804df3c11d2e8112aa08d64f699b85
Cr-Commit-Position: refs/heads/master@{#379567}

Powered by Google App Engine
This is Rietveld 408576698