device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc - Issue 176693003: chromeos: Make dbus::MessageReader memory ownership explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

Issue 176693003: chromeos: Make dbus::MessageReader memory ownership explicit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update a few more callers Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

diff --git a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

index 41ac37e0c8bf9a239f2f420f9f5b584205f52549..5df7ef00c098adf4f934e5198a9f5c8d31fdcf52 100644

--- a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

+++ b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

@@ -349,7 +349,7 @@ class MediaTransferProtocolDaemonClientImpl

return;

}

- uint8* data_bytes = NULL;

+ const uint8* data_bytes = NULL;

size_t data_length = 0;

dbus::MessageReader reader(response);

if (!reader.PopArrayOfBytes(&data_bytes, &data_length)) {

« chromeos/dbus/debug_daemon_client.cc ('K') | « dbus/message_unittest.cc ('k') | no next file » | no next file with comments »